This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [fixme] another case statement without a break -- intentional?
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Michael Snyder <msnyder at vmware dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Mon, 28 Feb 2011 08:14:21 +0400
- Subject: Re: [fixme] another case statement without a break -- intentional?
- References: <4D696633.9090207@vmware.com>
> Joel, can I ask you for a judgement call?
> Michael
Yes, the fallthrough seems to be by-design, but I will ask Paul,
who wrote that code.
Thanks,
--
Joel
> Index: ada-exp.y
> ===================================================================
> RCS file: /cvs/src/src/gdb/ada-exp.y,v
> retrieving revision 1.41
> diff -u -p -u -p -r1.41 ada-exp.y
> --- ada-exp.y 1 Jan 2011 15:32:55 -0000 1.41
> +++ ada-exp.y 26 Feb 2011 20:42:51 -0000
> @@ -920,6 +920,7 @@ write_object_renaming (struct block *ori
> break;
> case 'L':
> slice_state = LOWER_BOUND;
> + /* FIXME --- fall through???? */
> case 'S':
> renaming_expr += 1;
> if (isdigit (*renaming_expr))
--
Joel