This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [fixme] Missing break statement in linux-record.c?


OK, committed as attached.


Hui Zhu wrote:
Hi Michael,

I think this part need a break.
Thanks for your check.

Best,
Hui

On Sun, Feb 27, 2011 at 06:14, Michael Snyder <msnyder@vmware.com> wrote:
Hui,

I can't decide if there was meant to be a break statement here.
Could you take a look please?  If the fall-through is intentional,
please just add a comment to say that.

Thanks,
Michael


Index: linux-record.c =================================================================== RCS file: /cvs/src/src/gdb/linux-record.c,v retrieving revision 1.13 diff -u -p -u -p -r1.13 linux-record.c --- linux-record.c 1 Jan 2011 15:33:10 -0000 1.13 +++ linux-record.c 26 Feb 2011 22:12:34 -0000 @@ -770,6 +770,7 @@ Do you want to stop the program?"), if (record_linux_sockaddr (regcache, tdep, tmpulongest, len)) return -1; } + /* FIXME --- missing break??? Intentional??? Comment please */ case gdb_sys_recv: { ULONGEST size;



2011-02-28  Michael Snyder  <msnyder@vmware.com>

	* linux-record.c (record_linux_system_call): Add missing
	break statement.

Index: linux-record.c
===================================================================
RCS file: /cvs/src/src/gdb/linux-record.c,v
retrieving revision 1.13
diff -u -p -u -p -r1.13 linux-record.c
--- linux-record.c	1 Jan 2011 15:33:10 -0000	1.13
+++ linux-record.c	28 Feb 2011 18:08:13 -0000
@@ -770,6 +770,8 @@ Do you want to stop the program?"),
         if (record_linux_sockaddr (regcache, tdep, tmpulongest, len))
           return -1;
       }
+      break;
+
     case gdb_sys_recv:
       {
         ULONGEST size;

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]