This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [rfa] std-regs.c, value_of_builtin_frame_pc_reg, don't bother checking for null frame.

From: Michael Snyder <msnyder at vmware dot com>
To: Pedro Alves <pedro at codesourcery dot com>
Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
Date: Tue, 01 Mar 2011 13:56:50 -0800
Subject: Re: [rfa] std-regs.c, value_of_builtin_frame_pc_reg, don't bother checking for null frame.
References: <4D6D5B44.9020500@vmware.com> <201103012139.59726.pedro@codesourcery.com> <201103012152.01746.pedro@codesourcery.com>

Pedro Alves wrote:

On Tuesday 01 March 2011 21:39:59, Pedro Alves wrote:
On Tuesday 01 March 2011 20:47:00, Michael Snyder wrote:
If frame is null, we will have crashed already from dereferencing it.
Yeah, looks like a left over from before the "there's always
a frame" changes years ago.
reversenull3.txt
  2011-03-01  Michael Snyder  <msnyder@vmware.com>
* std-regs.c (value_of_builtin_frame_pc_reg): Frame can't be null.
Okay.
Similar dead code in value_of_builtin_frame_fp_reg btw.

Got it. Checked in.

References:
- [rfa] std-regs.c, value_of_builtin_frame_pc_reg, don't bother checking for null frame.
  - From: Michael Snyder
- Re: [rfa] std-regs.c, value_of_builtin_frame_pc_reg, don't bother checking for null frame.
  - From: Pedro Alves
- Re: [rfa] std-regs.c, value_of_builtin_frame_pc_reg, don't bother checking for null frame.
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]