This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: libiberty/cplus-dem.c, ada-demangle: plug memory leak.
- From: Tristan Gingold <gingold at adacore dot com>
- To: Michael Snyder <msnyder at vmware dot com>
- Cc: Jakub Jelinek <jakub at redhat dot com>, "dj at redhat dot com" <dj at redhat dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 4 Mar 2011 10:33:59 +0100
- Subject: Re: libiberty/cplus-dem.c, ada-demangle: plug memory leak.
- References: <4D70061C.10904@vmware.com> <20110303213008.GY30899@tyan-ft48-01.lab.bos.redhat.com> <4D700F5D.2030109@vmware.com>
On Mar 3, 2011, at 10:59 PM, Michael Snyder wrote:
> Jakub Jelinek wrote:
>> On Thu, Mar 03, 2011 at 01:20:28PM -0800, Michael Snyder wrote:
>>> 2011-03-03 Michael Snyder <msnyder@vmware.com>
>>>
>>> * libiberty/cplus-dem.c (ada_demangle): Stop memory leak.
>>> Also fix a one line indent problem.
>> No libiberty/ in libiberty/ChangeLog.
>>> @@ -1129,10 +1129,11 @@ ada_demangle (const char *mangled, int o
>>> unknown:
>>> len0 = strlen (mangled);
>>> + xfree (demangled);
>>> demangled = XNEWVEC (char, len0 + 3);
>> xfree isn't ever used in libiberty/*, use either free, or
>> XDELETE/XDELETEVEC. In fact, it seems to be defined only in gdb,
>> making cplus-dem.c dependent on gdb is obviously a wrong thing.
>
> Thanks for the review.
>
> How's this?
> + if (demangled != NULL)
> + free (demangled);
No need to check that demangled is not NULL.
(Nice catches!)
Tristan.