This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Fix decode_indirect to use parse_to_comma_and_eval


On Tue, 2011-03-01 at 10:07 -0700, Tom Tromey wrote:
> >>>>> "Thiago" == Thiago Jung Bauermann <bauerman@br.ibm.com> writes:
> 
> Thiago> This came up in the discussion about the ranged breakpoints patch. I
> Thiago> needed the break-range command to accept locations of the form *PC in a
> Thiago> string of the form "*PC_START, *PC_END" but couldn't call
> Thiago> parse_breakpoint_sals because decode_indirect (called by decode_line_1)
> Thiago> tried to read past the comma and got confused. Ulrich mentioned that it
> Thiago> should stop at the comma. This patch implements that.
> 
> Usually I am opposed to incompatible changes, but this one seems fairly
> harmless to me.  It seems unlikely that anybody ever uses a "," in an
> expression in a linespec.
> 
> Thiago> No regressions on ppc-linux and ppc64-linux. Ok?
> 
> If there are no objections by Friday, please go ahead.

Since there were no objections, I've just committed it. Thanks!

-- 
[]'s
Thiago Jung Bauermann
IBM Linux Technology Center


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]