This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Fix decode_indirect to use parse_to_comma_and_eval
- From: Thiago Jung Bauermann <bauerman at br dot ibm dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches ml <gdb-patches at sourceware dot org>
- Date: Fri, 04 Mar 2011 17:08:39 -0300
- Subject: Re: [RFA] Fix decode_indirect to use parse_to_comma_and_eval
- References: <1298493740.3172.28.camel@hactar> <m3r5aq6a6o.fsf@fleche.redhat.com>
On Tue, 2011-03-01 at 10:07 -0700, Tom Tromey wrote:
> >>>>> "Thiago" == Thiago Jung Bauermann <bauerman@br.ibm.com> writes:
>
> Thiago> This came up in the discussion about the ranged breakpoints patch. I
> Thiago> needed the break-range command to accept locations of the form *PC in a
> Thiago> string of the form "*PC_START, *PC_END" but couldn't call
> Thiago> parse_breakpoint_sals because decode_indirect (called by decode_line_1)
> Thiago> tried to read past the comma and got confused. Ulrich mentioned that it
> Thiago> should stop at the comma. This patch implements that.
>
> Usually I am opposed to incompatible changes, but this one seems fairly
> harmless to me. It seems unlikely that anybody ever uses a "," in an
> expression in a linespec.
>
> Thiago> No regressions on ppc-linux and ppc64-linux. Ok?
>
> If there are no objections by Friday, please go ahead.
Since there were no objections, I've just committed it. Thanks!
--
[]'s
Thiago Jung Bauermann
IBM Linux Technology Center