This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [commit] linux-tdep.c (linux_get_siginfo_type): Stop memory leak.
- From: Michael Snyder <msnyder at vmware dot com>
- To: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Sat, 05 Mar 2011 13:22:13 -0800
- Subject: Re: [commit] linux-tdep.c (linux_get_siginfo_type): Stop memory leak.
- References: <4D72A878.6000104@vmware.com>
Michael Snyder wrote:
arch_type calls xstrdup, so no need for the caller to do it.
checked in.
Actually, found several more instances in the same function.
2011-03-05 Michael Snyder <msnyder@vmware.com>
* linux-tdep.c (linux_get_siginfo_type): Stop memory leak.
Index: linux-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/linux-tdep.c,v
retrieving revision 1.10
diff -u -p -r1.10 linux-tdep.c
--- linux-tdep.c 1 Jan 2011 15:33:10 -0000 1.10
+++ linux-tdep.c 5 Mar 2011 21:20:37 -0000
@@ -76,20 +76,20 @@ linux_get_siginfo_type (struct gdbarch *
append_composite_type_field (sigval_type, "sival_ptr", void_ptr_type);
/* __pid_t */
- pid_type = arch_type (gdbarch, TYPE_CODE_TYPEDEF, TYPE_LENGTH (int_type),
- xstrdup ("__pid_t"));
+ pid_type = arch_type (gdbarch, TYPE_CODE_TYPEDEF,
+ TYPE_LENGTH (int_type), "__pid_t");
TYPE_TARGET_TYPE (pid_type) = int_type;
TYPE_TARGET_STUB (pid_type) = 1;
/* __uid_t */
- uid_type = arch_type (gdbarch, TYPE_CODE_TYPEDEF, TYPE_LENGTH (uint_type),
- xstrdup ("__uid_t"));
+ uid_type = arch_type (gdbarch, TYPE_CODE_TYPEDEF,
+ TYPE_LENGTH (uint_type), "__uid_t");
TYPE_TARGET_TYPE (uid_type) = uint_type;
TYPE_TARGET_STUB (uid_type) = 1;
/* __clock_t */
- clock_type = arch_type (gdbarch, TYPE_CODE_TYPEDEF, TYPE_LENGTH (long_type),
- xstrdup ("__clock_t"));
+ clock_type = arch_type (gdbarch, TYPE_CODE_TYPEDEF,
+ TYPE_LENGTH (long_type), "__clock_t");
TYPE_TARGET_TYPE (clock_type) = long_type;
TYPE_TARGET_STUB (clock_type) = 1;