This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [revert patch] Remove configure/make in common/

On 03/09/2011 12:18 PM, Joel Brobecker wrote:
> This looks good to me. I also did some testing on my own, verifying
> the few issues I noticed (Eg. "make configure-gdb; make clean",
> very that autoconf, autoheader et al do not get called, etc).
> So, let's go ahead and commit.
> 
>> > @@ -337,6 +331,7 @@ SUBDIR_PYTHON_DEPS =
>> >  SUBDIR_PYTHON_LDFLAGS=
>> >  SUBDIR_PYTHON_CFLAGS=
>> >  
>> > +
>> >  # Opcodes currently live in one of two places.  Either they are in the
> This part does not need reverting, though (this is a good example of
> why it's better to avoid mixing formatting changes with real changes,
> when they are independent).

Thanks for the review.  Remove this chunk.  Applied.

-- 
Yao (éå)
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]