This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] [python] Implement stop_p for gdb.Breakpoint
On Fri, Mar 11, 2011 at 9:43 AM, Tom Tromey <tromey@redhat.com> wrote:
> Phil> +/* Function that is called when a Python condition is evaluated. ?*/
> Phil> +char *stop_func = "stop";
>
> `static const'
Better, static const char stop_func[] = "stop";
Or static const char* const stop_func.
[Assuming the code that uses this doesn't cough, sigh.]
Plus blank line between function comment and definition please.
[Your very good at catching all other style issues ...]
+/* Helper function that overrides this Python object's
+ PyObject_GenericSetAttr to allow extra validation of the attribute
+ being set. */
+static int
+local_setattro (PyObject *self, PyObject *name, PyObject *v)