Re: [PATCH] Add 'getthrds' declaration check in configure for AIX

[Pedro Alves <pedro at codesourcery dot com>]

On Wednesday 16 March 2011 01:40:23, Joel Brobecker wrote:
> > > +# Older versions of AIX do not provide the declaration for the getthrds
> > > +# function (it appears that it was introduced with AIX 6.x).
> > > +AC_CHECK_DECLS(getthrds, [], [], [[#include <procinfo.h>]])
> > > +
> > 
> > Any reason this isn't done close to where we check for AIX
> > thread support, and decide to whether to build aix-thread.c in the
> > first place?  Look for "AiX thread debugging library" further down.
> 
> No specific reason, no. I placed the check there because it seemed
> to be the general area where we make cheks of this kind (checks for
> library functions, ptrace prototypes, etc).  But I'm happy to move
> it next to the AIX thread detection check.  We could even perform
> the check on AIX only, although I had the feeling that we usually
> this type of check regardless of the host (this is the case for
> the ptrace checks, for instance).

I just thought it made sense to keep the aix thread support
checks together, and that you might have missed the existing code.
If you want to keep them where you were putting them, it's fine
with me.

(I think the ptrace checks are where they are for both historical
reasons, and for the fact that the ptrace support is built by
several different hosts (inf-ptrace.c), with slightly different
ptrace implentations, and that nobody ever bothered to make them
run only on hosts that require them, and that are building the native
debugger backend.  Library functions used by common code need to be
checked in all hosts, of course.)

-- 
Pedro Alves