This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch 1/7] Support a ring of related breakpoints


>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> currently breakpoint->related_breakpoint is used only to connect
Jan> two related breakpoints.  During STT_GNU_IFUNC one thread can be in
Jan> the resolver while another thread also enters the resolver.  But
Jan> both threads will have a different return address where GDB wants
Jan> to fetch the resolved address.  Therefore one needs to track
Jan> arbitrary number of the return address breakpoints while still
Jan> catching new entries to the STT_GNU_IFUNC resolver.

I read this and it looks fine to me.

At first I didn't see how a ring was actually created, but the only set
of this field is in watch_command_1, and it links the two together:

      b->related_breakpoint = scope_breakpoint;
      scope_breakpoint->related_breakpoint = b;

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]