This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch 1/7] Support a ring of related breakpoints
- From: Tom Tromey <tromey at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 21 Mar 2011 14:06:25 -0600
- Subject: Re: [patch 1/7] Support a ring of related breakpoints
- References: <20110319211505.GB30867@host1.jankratochvil.net>
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> currently breakpoint->related_breakpoint is used only to connect
Jan> two related breakpoints. During STT_GNU_IFUNC one thread can be in
Jan> the resolver while another thread also enters the resolver. But
Jan> both threads will have a different return address where GDB wants
Jan> to fetch the resolved address. Therefore one needs to track
Jan> arbitrary number of the return address breakpoints while still
Jan> catching new entries to the STT_GNU_IFUNC resolver.
I read this and it looks fine to me.
At first I didn't see how a ring was actually created, but the only set
of this field is in watch_command_1, and it links the two together:
b->related_breakpoint = scope_breakpoint;
scope_breakpoint->related_breakpoint = b;
Tom