This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch 2/2] Code cleanup: c_type_print_args's show_artificial
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: gdb-patches at sourceware dot org
- Cc: Keith Seitz <keiths at redhat dot com>
- Date: Tue, 22 Mar 2011 18:36:57 +0100
- Subject: Re: [patch 2/2] Code cleanup: c_type_print_args's show_artificial
- References: <20110206181631.GB30439@host1.dyn.jankratochvil.net>
On Sun, 06 Feb 2011 19:16:31 +0100, Jan Kratochvil wrote:
> if [patch 1/2] goes in this is just a code cleanup, SHOW_ARTIFICIAL parameter
> meaning is no longer much about the show-artificial meaning.
>
> gdb/
> 2011-02-06 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> Code cleanup.
> * c-typeprint.c (c_type_print_args): Change parameter show_artificial
> to linkage_name. Invert its value. Update the function comment.
> (c_type_print_varspec_suffix): Invert it at the caller.
> * dwarf2read.c (dwarf2_compute_name): Invert it at the caller.
Checked in:
http://sourceware.org/ml/gdb-cvs/2011-03/msg00267.html
As the current code became confusing with the former naming changed after my
former commit of:
[patch 1/2] Fix physname regression: c/v types quals (PR c++/12328)
http://sourceware.org/ml/gdb-patches/2011-02/msg00112.html
No regressions on {x86_64,x86_64-m32,i686}-fedora15-linux-gnu.
Thanks,
Jan