This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[RFA] Missing files in Makefile.in



> -----Message d'origine-----
> De?: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Tom Tromey
> Envoyé?: vendredi 25 mars 2011 17:06
> À?: Pierre Muller
> Cc?: gdb-patches@sourceware.org
> Objet?: Re: [RFC] Missing files in Makefile.in
> 
> >>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
writes:
> 
> Pierre> List of not listed headers:
> [...]
> 
> Pierre> List of not listed c sources:
> [...]
> 
> I think headers and source files only really need to be listed for TAGS.
> It would be great to list them all, though.
> 
> Pierre>   I also noticed that there are
> Pierre> files located in gdbserver subdirectory
> Pierre> that are listed in this Makefile.in...
> 
> I don't know about this one.  For TAGS it seems like the wrong thing;
> gdbserver should have its own TAGS file.
> 
> Pierre> Should we do something about those
> Pierre> inconsistencies?
> 
> Yes please :-)
> 
> It would be nice to move to a more Automake-like scheme, where the build
> sources mention source files only, and then we use .c->.o substitutions
> to list the object files.  Or, we could just switch to Automake.  
  But here I don't know if patsubst can be used, as this Makefile
is supposed to also accepted non-GNU make...
  Wtihout patsubst, I don't know how to remove the subdir part
to convert the C sources to their corresponding objects (which have no
subdir part).

>Either of these is likely to be a pain though; if you want to just patch up
the
> existing stuff, that is totally fine.

Here is a quick-and-dirty fix of the files I found...
I added headers from:
gnulib/extra/ subdirectory, but I am not sure this is correct.
I left the C sources from gnulib out because
none was listed until now, I also don't know if those should
or should not added.

Is this patch OK?

Pierre

PS: Using the script I inserted in the first email of this thread
it would be fairly easy to create an ordered list of the different
lists.

2011-03-29  Pierre Muller  <muller@ics.u-strasbg.fr>

	* Makefile.in (SFILES): Add missing C sources.
	(HFILES_NO_SRCDIR): Remove gdbserver subdirectory headers.
	Add missing headers.

Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.1163
diff -u -p -r1.1163 Makefile.in
--- Makefile.in	9 Mar 2011 06:10:37 -0000	1.1163
+++ Makefile.in	29 Mar 2011 13:01:55 -0000
@@ -235,13 +235,16 @@ SUBDIR_TUI_OBS = \
 	tui-io.o \
 	tui-layout.o \
 	tui-out.o \
+	tui-main.o \
 	tui-regs.o \
 	tui-source.o \
 	tui-stack.o \
 	tui-win.o \
 	tui-windata.o \
 	tui-wingeneral.o \
-	tui-winsource.o
+	tui-winsource.o \
+	tui.o
+
 SUBDIR_TUI_SRCS = \
 	tui/tui-command.c \
 	tui/tui-data.c \
@@ -251,6 +254,7 @@ SUBDIR_TUI_SRCS = \
 	tui/tui-interp.c \
 	tui/tui-io.c \
 	tui/tui-layout.c \
+	tui/tui-main.c \
 	tui/tui-out.c \
 	tui/tui-regs.c \
 	tui/tui-source.c \
@@ -260,6 +264,7 @@ SUBDIR_TUI_SRCS = \
 	tui/tui-wingeneral.c \
 	tui/tui-winsource.c \
 	tui/tui.c
+
 SUBDIR_TUI_DEPS =
 SUBDIR_TUI_LDFLAGS=
 SUBDIR_TUI_CFLAGS= \
@@ -732,6 +737,8 @@ SFILES = ada-exp.y ada-lang.c ada-typepr
 	record.c gcore.c \
 	jit.c \
 	xml-syscall.c \
+	annotate.c common/signals.c copying.c dfp.c gdb.c inf-child.c \
+	regset.c sol-thread.c windows-termcap.c
 
 LINTFILES = $(SFILES) $(YYFILES) $(CONFIG_SRCS) init.c
 
@@ -758,11 +765,8 @@ c-lang.h d-lang.h frame.h event-loop.h b
 cli/cli-decode.h cli/cli-cmds.h cli/cli-dump.h cli/cli-utils.h \
 cli/cli-script.h macrotab.h symtab.h version.h gnulib/wchar.in.h \
 gnulib/string.in.h gnulib/str-two-way.h \
-gnulib/stdint.in.h remote.h gdb.h sparc-nat.h gdbserver/win32-low.h \
-gdbserver/i387-fp.h gdbserver/server.h gdbserver/terminal.h \
-gdbserver/mem-break.h gdbserver/wincecompat.h gdbserver/target.h \
-gdbserver/linux-low.h gdbserver/gdb_proc_service.h \
-gdbserver/regcache.h gdbthread.h dwarf2-frame.h nbsd-nat.h dcache.h \
+gnulib/stdint.in.h remote.h gdb.h sparc-nat.h \
+gdbthread.h dwarf2-frame.h nbsd-nat.h dcache.h \
 amd64-nat.h s390-tdep.h arm-linux-tdep.h exceptions.h macroscope.h \
 gdbarch.h bsd-uthread.h gdb_thread_db.h gdb_stat.h memory-map.h
memrange.h \
 mdebugread.h m88k-tdep.h stabsread.h hppa-linux-offsets.h linux-fork.h \
@@ -801,7 +805,16 @@ annotate.h sim-regno.h dictionary.h dfp.
 remote-fileio.h i386-linux-tdep.h vax-tdep.h objc-lang.h \
 sentinel-frame.h bcache.h symfile.h windows-tdep.h linux-tdep.h \
 gdb_usleep.h jit.h xml-syscall.h microblaze-tdep.h \
-psymtab.h psympriv.h progspace.h bfin-tdep.h ia64-hpux-tdep.h
+psymtab.h psympriv.h progspace.h bfin-tdep.h ia64-hpux-tdep.h \
+amd64-darwin-tdep.h charset-list.h common/gdb_signals.h
common/i386-xstate.h \
+config/djgpp/langinfo.h config/djgpp/nl_types.h darwin-nat.h \
+dicos-tdep.h filesystem.h gcore.h gdb_wchar.h hppabsd-tdep.h \
+i386-darwin-tdep.h i386-nat.h linux-record.h moxie-tdep.h \
+osdata.h procfs.h python/py-event.h python/py-events.h
python/py-stopevent.h \
+python/python-internal.h python/python.h ravenscar-thread.h record.h \
+solib-darwin.h solib-ia64-hpux.h solib-spu.h windows-nat.h xcoffread.h \
+gnulib/extra/arg-nonnull.h gnulib/extra/c++defs.h
gnulib/extra/warn-on-use.h \
+gnulib/stddef.in.h inline-frame.h
 
 # Header files that already have srcdir in them, or which are in objdir.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]