This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [try 2nd 3/8] Refactor copy_svc_os

From: Yao Qi <yao at codesourcery dot com>
To: gdb-patches at sourceware dot org
Date: Thu, 07 Apr 2011 12:18:50 +0800
Subject: Re: [try 2nd 3/8] Refactor copy_svc_os
References: <201104062055.p36KtdDi009302@d06av02.portsmouth.uk.ibm.com>

On 04/07/2011 04:55 AM, Ulrich Weigand wrote:
> Yao Qi wrote:
> 
>> 2011-03-24  Yao Qi  <yao@codesourcery.com>
>>
>> 	* gdb/arm-linux-tdep.c (arm_linux_copy_svc): Remove parameters INSN
>> 	and TO.
>> 	* gdb/arm-tdep.c (cleanup_svc): Handle variable instruction size.
>> 	(arm_copy_svc): Remove parameters INSN and TO.
>> 	(decode_svc_copro): Update caller.
>> 	* gdb/arm-tdep.h (struct displaced_step_closure): Remove parameters
>> 	from function pointer `copy_svc_os'.
> 
> This looks OK to me.
> 

Thanks for the review.  Applied to trunk.
http://sourceware.org/ml/gdb-cvs/2011-04/msg00047.html

-- 
Yao (éå)

References:
- Re: [try 2nd 3/8] Refactor copy_svc_os
  - From: Ulrich Weigand

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]