This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [try 2nd, patch] Move common macros to i386-dbg-reg.h
- From: Mark Kettenis <mark dot kettenis at xs4all dot nl>
- To: yao at codesourcery dot com
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 7 Apr 2011 17:53:25 +0200 (CEST)
- Subject: Re: [try 2nd, patch] Move common macros to i386-dbg-reg.h
- References: <4D57AB12.1050708@codesourcery.com> <4D79AD80.5050803@codesourcery.com> <4D9167CD.4070205@codesourcery.com> <4D9DC513.6040403@codesourcery.com>
> Date: Thu, 07 Apr 2011 22:07:15 +0800
> From: Yao Qi <yao@codesourcery.com>
>
> On 03/29/2011 01:02 PM, Yao Qi wrote:
> > On 03/11/2011 01:05 PM, Yao Qi wrote:
> >> Compared with last version, two changes are in this new patch,
> >> 1) rename i386-common.h to i386-dbg-reg.h,
> >> 2) add dependency tracking in gdbserver.
> >>
> >> OK for mainline after 7.3 branch is created?
> >>
> >> gdb/
> >>
> >> * i386-nat.h: Include i386-dbg-reg.h.
> >> Move macros to i386-dbg-reg.h.
> >> * i386-nat.c: Move macros and structs to i386-dbg-reg.h.
> >> New variable struct i386_debug_reg_state state to replace
> >> other variables dr_mirror, dr_ref_count, dr_control_mirror,
> >> and dr_status_mirror.
> >> (i386_insert_aligned_watchpoint): Add one formal parameter
> >> struct i386_debug_reg_state *STATE.
> >> Update code using these variables.
> >> (i386_remove_aligned_watchpoint, i386_show_dr): Likewise.
> >> (i386_cleanup_dregs): Likewise.
> >> (i386_handle_nonaligned_watchpoint): Likewise.
> >> * common/i386-dbg-reg.h: New. Common macros and structs.
> >>
> >> gdb/gdbserver/
> >>
> >> * i386-low.h: Include i386-dbg-reg.h.
> >> Move macros to i386-dbg-reg.h.
> >> * i386-low.c (i386_set_debug_register_length): New.
> >> (i386_low_init_dregs): Call i386_set_debug_register_length.
> >> * Makefile.in (i386_low_h) Depends on i386-dbg-reg.h.
> >
> > Ping.
> >
>
> Ping?
Sorry, but as long as there is no clear vision of what gdbsever should
be (a fully featured native GDB replacement or a lightweight remote
protocol stub) and how to handle the configure mess, I'm hesitant to
review diffs.
Also, posting pings without a pointer to the actual diff isn't helping
either.