This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [RFA 1/2] Remove old Cygwin1.5 support


> >The first two patches concern the removal of Cygwin 1.5 support has he
> >suggested. This allows some simplifications in windows-nat.c code
> >and I will try to further reduce cygwin/mingw differences in subsequent
> >patches.
> >
> >This first part just removes the macros that are used to support Cygwin
1.5
> >in remote-fileio.c and windows-nat.c
> >The second part updates gdbserver/win32-low.c to use the
> >new cygwin_conv_path and cygwin_conv_path_list functions
> >in order to avoid build failure due to deprecated warning.
> >
> >Does anyone object to the idea of removing old Cygwin support?
> >Christopher, is this patch acceptable as is?
> >
> >Pierre Muller.
> >
> >2011-04-07  Pierre Muller  <muller@ics.u-strasbg.fr>
> >
> >	Remove support for old Cygwin 1.5 versions.
> >	* remote-fileio.c: Remove macros used to emulate new
> >cygwin_conv_path
> >	function on old Cygwin version.
> >	* windows-nat.c: Remove cygwin version check and always define
> >	__USEWIDE for Cygwin compilation.
> 
> Looks good.  Please check in.  

Thanks for the approval,
patch checked in.

> I can't approve the gdbserver patch since
> I don't believe I have that privilege.
Maybe Pedro can?
Patch is in:
http://sourceware.org/ml/gdb-patches/2011-04/msg00100.html

Pierre Muller


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]