This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch 2/3 ppc64] Provide new sym_read parameter ADDRS


On Wed, 06 Apr 2011 22:41:22 +0200, Ulrich Weigand wrote:
> I'm just wondering if it wouldn't be simpler, instead of passing the extra
> argument to all the _read function, to fix the problem that _backlink is
> set too late.
> 
> For example, couldn't you add a "parent" objfile parameter to
> symbol_file_add_with_addrs_or_offsets, and have it set the
> _backlink as soon as the new objfile is allocated, before ever
> calling syms_from_objfile?
> 
> Then, elfread.c could simply check _backlink to get at the original
> objfile.

Done.  It was not possible before as ADDRS was still needed but this may no
longer be true after your comment on [patch 3/3].

To be reposted as #3.


Thanks,
Jan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]