This is the mail archive of the
mailing list for the GDB project.
RE: [RFC] Add support for locally modified environment variables for windows-nat.c
- From: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- To: <gdb-patches at sourceware dot org>
- Cc: "'Corinna Vinschen'" <vinschen at redhat dot com>
- Date: Wed, 20 Apr 2011 14:05:43 +0200
- Subject: RE: [RFC] Add support for locally modified environment variables for windows-nat.c
- References: <000601cbff45$66fa5820$34ef0860$@firstname.lastname@example.org> <20110420115528.GA5842@calimero.vinschen.de>
> -----Message d'origine-----
> De : email@example.com [mailto:gdb-patches-
> firstname.lastname@example.org] De la part de Corinna Vinschen
> EnvoyÃ : mercredi 20 avril 2011 13:55
> Ã : email@example.com
> Objet : Re: [RFC] Add support for locally modified environment variables for
> On Apr 20 12:26, Pierre Muller wrote:
> > A while ago
> > Sebastian Puebla submitted a patch for
> > support of locally modified environment variables.
> > http://sourceware.org/ml/gdb-patches/2010-05/msg00317.html
> > http://sourceware.org/ml/gdb-patches/2010-08/msg00026.html
> > http://sourceware.org/ml/gdb-patches/2010-11/msg00128.html
> > Nevertheless, I suspect that his patch would not have worked for Cygwin,
> > because Cygwin converts several environment variables
> > from windows style to POSIX style.
> Do you suspect or did you actually test it? What you're trying to
> accomplish is actually the task of the
> cygwin_internal (CW_SYNC_WINENV);
> call right before calling CreateProcess. This allows to keep the actual
> underlying details of the environment handling entirely in the hands of
> Cygwin. Especially copying an internal list of env vars from Cygwin
> into GDB makes me very uncomfortable since this is bound to break as
> soon as we decide to handle things a bit different in Cygwin.
The problem is that this does not handle
(gdb) set environment TEST=My dummy test
which is supposed to be passed to the inferior.
after the commands above the in_env char * vector
will have an additional entry "TEST=My dummy test"
but the internal environment variables of GDB itself
are not changed.
I suspect that cygwin_internal (CW_SYNC_WINENV);
only acts on the environment variables of GDB itself.
Does that mean that we should instead copy this in_env
array using cygwin set_env function before calling cygwin_internal?
If this is true, do we need to restore the environment state of GDB
> Of course it's cgf's call, but I don't think this is the right thing to
> do. If this is actually broken, it's the cygwin_internal(CW_SYNC_WINENV)
> implementation in Cygwin which should be fixed, rather than GDB going
> out of its way to emulate what happens in Cygwin internally.
Thanks you for explaining the cygwin_internal call.
Of course my current patch does invalidate this as out_env array is used
instead of the current GDB environment variables.
If you think that the proposal above is the right track for
Cygwin, I will try to implement this.