Re: [PATCH] Support for enabling/disabling tracepoints while a trace experiment is running

[Pedro Alves <pedro at codesourcery dot com>]

On Monday 09 May 2011 20:31:10, Kwok Cheung Yeung wrote:
>         gdb/
>         * breakpoint.c (disable_breakpoint): Disable all locations
>         associated with a tracepoint on target if a trace experiment is
>         running.
>         (disable_command): Disable a specific tracepoint location on target if
>         a trace experiment is running.
>         (do_enable_breakpoint): Enable all locations associated with a
>         tracepoint on target if a trace experiment is running.
>         (enable_command) Enable a specific tracepoint location on target if a
>         trace experiment is running.
>         * target.c (update_current_target): Add INHERIT and de_fault clauses for
>         to_supports_enable_disable_tracepoint, to_enable_tracepoint and
>         to_disable_tracepoint.
>         * target.h: Add declaration of struct bp_location.
>         (struct target_ops): Add new functions
>         to_supports_enable_disable_tracepoint, to_enable_tracepoint and
>         to_disable_tracepoint to target operations.
>         (target_supports_enable_disable_tracepoint): New macro.
>         (target_enable_tracepoint): New macro.
>         (target_disable_tracepoint): New macro.
>         * remote.c (struct remote_state): Add new field.
>         (remote_enable_disable_tracepoint_feature): New.
>         (remote_protocol_features): Add new entry.
>         (remote_supports_enable_disable_tracepoint): New.
>         (remote_enable_tracepoint): New.
>         (remote_disable_tracepoint): New.
>         (init_remote_ops): Add remote_enable_tracepoint,
>         remote_disable_tracepoint and remote_supports_enable_disable_tracepoint
>         to remote operations.
>         * tracepoint.c (start_tracing): Allow tracing to start without any
>         tracepoints enabled with just a warning if they can be re-enabled
>         later.

Okay.

> 
>         gdb/gdbserver/
>         * server.c (handle_query): Add EnableDisableTracepoints to the list
>         of supported features.
>         * tracepoint.c (clear_installed_tracepoints): Uninstall disabled
>         tracepoints.
>         (cmd_qtenable_disable): New.
>         (cmd_qtstart): Install tracepoints even if disabled.
>         (handle_tracepoint_general_set): Add call to cmd_qtenable_disable on
>         receiving a QTEnable or QTDisable packet.
>         (gdb_collect): Skip data collection if fast tracepoint is disabled.
>         (ust_marker_to_static_tracepoint): Do not ignore disabled static
>         tracepoints.
>         (gdb_probe): Skip data collection if static tracepoint is disabled.

Okay.

-- 
Pedro Alves