Re: PATCH : allow to set length of hw watchpoints (e.g. for Valgrind gdbserver)

[Eli Zaretskii <eliz at gnu dot org>]

> From: "Philippe Waroquiers" <philippe.waroquiers@skynet.be>
> Date: Sun, 15 May 2011 19:38:44 +0200
> 
> With the last svn Valgrind, and this patch, the following
> watchpoint will be handled at a reasonable (i.e. "valgrind")
> speed:
> In the program being debugged:
>   char s[1000];
> 
> in gdb:
>   awatch s
> 
> as the hardware watchpoint will be accepted by the valgrind
> gdbserver, and implemented using Valgrind validity bits
> mechanism.

If this is accepted, I think this is NEWS worthy.

A few comments to the documentation part:

> + @item set remote hardware-watchpoint-length-limit @var{limit}
> + Restrict @value{GDBN} to using @var{limit} for the maximum length of
> + remote hardware watchpoints.  A limit of -1, the default, is treated
> + as unlimited.

I think we should tell explicitly that the limit is in bytes.  (Btw,
why the corresponding data types are `int' and not `ssize_t'?)

Also, I think we also document the "show" counterpart of each "set"
command.

Thanks.