This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [gcc patch 1/3] cp-demangle.c: Make `options' a parameter
- From: Ian Lance Taylor <iant at google dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, gdb-patches at sourceware dot org
- Date: Mon, 13 Jun 2011 11:06:21 -0700
- Subject: Re: [gcc patch 1/3] cp-demangle.c: Make `options' a parameter
- References: <20110602141532.GB15093@host1.jankratochvil.net>
On Thu, Jun 2, 2011 at 7:15 AM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
>
> libiberty/
> 2011-05-24 ?Jan Kratochvil ?<jan.kratochvil@redhat.com>
>
> ? ? ? ?* cp-demangle.c (struct d_print_info): Remove field options.
> ? ? ? ?(d_print_init): Remove parameter options.
> ? ? ? ?(cplus_demangle_print_callback): Update all the callers.
> ? ? ? ?(d_print_comp, d_print_mod_list, d_print_mod, d_print_function_type)
> ? ? ? ?(d_print_array_type, d_print_expr_op, d_print_cast, d_print_subexpr):
> ? ? ? ?Add parameter options, update all the callers.
> ?static void
> -d_print_comp (struct d_print_info *, const struct demangle_component *);
> +d_print_comp (struct d_print_info *, const struct demangle_component *, int);
The new options parameter should be the second parameter, not the last.
> ?static void
> -d_print_mod_list (struct d_print_info *, struct d_print_mod *, int);
> +d_print_mod_list (struct d_print_info *, struct d_print_mod *, int, int);
Likewise.
> ?static void
> -d_print_mod (struct d_print_info *, const struct demangle_component *);
> +d_print_mod (struct d_print_info *, const struct demangle_component *, int);
Likewise.
> ?static void
> ?d_print_function_type (struct d_print_info *,
> ? ? ? ? ? ? ? ? ? ? ? ?const struct demangle_component *,
> - ? ? ? ? ? ? ? ? ? ? ? struct d_print_mod *);
> + ? ? ? ? ? ? ? ? ? ? ? struct d_print_mod *, int);
Likewise.
> ?static void
> ?d_print_array_type (struct d_print_info *,
> ? ? ? ? ? ? ? ? ? ? const struct demangle_component *,
> - ? ? ? ? ? ? ? ? ? ?struct d_print_mod *);
> + ? ? ? ? ? ? ? ? ? ?struct d_print_mod *, int);
Likewise.
> ?static void
> -d_print_expr_op (struct d_print_info *, const struct demangle_component *);
> +d_print_expr_op (struct d_print_info *, const struct demangle_component *, int);
Likewise.
> ?static void
> -d_print_cast (struct d_print_info *, const struct demangle_component *);
> +d_print_cast (struct d_print_info *, const struct demangle_component *, int);
Likewise.
You will have to change the function definitions and calls accordingly.
This is OK with those changes.
Thanks.
Ian