This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] [python] Implement Inferior.current_inferior
Joel Brobecker <brobecker@adacore.com> writes:
>> Whether your patch, or mine makes it in I don't mind. The patches looks
>> similar, but mine has a few extra tests and accounts for the reference
>> leaking/sigsegv. I would be happy to add your name to the ChangeLog as
>> co-implementer if the maintainers think this is ok (and they approve the
>> patch).
>
> It could be a merge of the two patches, with both names on the CL,
> I think.
As our patches are basically the same, the merge would not really be
needed. Apart from the reference counting hunks, they are basically the
same. I would take my patch which deals with the reference counting
issue and add Kevin's name to the ChangeLog. (At least to me that is the
cleanest way to do it other than trying to merge two very similar
patches.)
My real question was: As Kevin is lost in FSF paperwork with substantial
delays, if it would be okay under the current FSF assignment rules to
co-credit the ChangeLog with Kevin as the author. It probably isn't - I
know some projects do this, but I have no experience with this scenario
in GDB. As Kevin has a previous implementation that is pending FSF
paperwork (I am not sure if his patch was reviewed), I think he should
have the first shot/discussion on that patch. I guess we have to just
wait?
Cheers,
Phil