This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[commit] Re: [patch] Remove DMGL_VERBOSE


On Thu, 02 Jun 2011 21:10:21 +0200, Jan Kratochvil wrote:
> gdb/
> 2011-06-02  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	* dwarf2read.c (dwarf2_physname): Remove DMGL_VERBOSE.
> 	* symtab.c (symbol_find_demangled_name): Likewise.
> 
> gdb/testsuite/
> 2011-06-02  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	* gdb.cp/no-dmgl-verbose.cc: New file.
> 	* gdb.cp/no-dmgl-verbose.exp: New file.

Checked in.  Mistaken gdb/Changelog needed a fix up commit.

dwarf2read.c (dwarf2_physname) was already modified this way in:
	[commit] Re: [patch] Follow DW_AT_linkage_name for methods #2
	http://sourceware.org/ml/gdb-patches/2011-07/msg00054.html


Thanks,
Jan


http://sourceware.org/ml/gdb-cvs/2011-07/msg00027.html
http://sourceware.org/ml/gdb-cvs/2011-07/msg00028.html

--- src/gdb/ChangeLog	2011/07/01 19:12:09	1.13149
+++ src/gdb/ChangeLog	2011/07/01 19:18:35	1.13150
@@ -1,4 +1,8 @@
 2011-07-01  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+	* symtab.c (symbol_find_demangled_name): Likewise.
+
+2011-07-01  Jan Kratochvil  <jan.kratochvil@redhat.com>
 	    Tom Tromey  <tromey@redhat.com>
 
 	* dwarf2read.c (check_physname): New variable.
--- src/gdb/ChangeLog	2011/07/01 19:18:35	1.13150
+++ src/gdb/ChangeLog	2011/07/01 19:19:13	1.13151
@@ -1,6 +1,6 @@
 2011-07-01  Jan Kratochvil  <jan.kratochvil@redhat.com>
 
-	* symtab.c (symbol_find_demangled_name): Likewise.
+	* symtab.c (symbol_find_demangled_name): Remove DMGL_VERBOSE.
 
 2011-07-01  Jan Kratochvil  <jan.kratochvil@redhat.com>
 	    Tom Tromey  <tromey@redhat.com>

--- src/gdb/symtab.c	2011/06/20 17:53:33	1.277
+++ src/gdb/symtab.c	2011/07/01 19:18:36	1.278
@@ -500,7 +500,7 @@
       || gsymbol->language == language_auto)
     {
       demangled =
-        cplus_demangle (mangled, DMGL_PARAMS | DMGL_ANSI | DMGL_VERBOSE);
+        cplus_demangle (mangled, DMGL_PARAMS | DMGL_ANSI);
       if (demangled != NULL)
 	{
 	  gsymbol->language = language_cplus;
--- src/gdb/testsuite/ChangeLog	2011/07/01 19:12:12	1.2773
+++ src/gdb/testsuite/ChangeLog	2011/07/01 19:18:36	1.2774
@@ -1,4 +1,9 @@
-2011-05-24  Jan Kratochvil  <jan.kratochvil@redhat.com>
+2011-07-01  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+	* gdb.cp/no-dmgl-verbose.cc: New file.
+	* gdb.cp/no-dmgl-verbose.exp: New file.
+
+2011-07-01  Jan Kratochvil  <jan.kratochvil@redhat.com>
 
 	* gdb.base/break-interp.exp (reach_1, test_ld): Allow also the prefix
 	__GI_.
--- src/gdb/testsuite/gdb.cp/no-dmgl-verbose.cc
+++ src/gdb/testsuite/gdb.cp/no-dmgl-verbose.cc	2011-07-01 19:19:27.158960000 +0000
@@ -0,0 +1,23 @@
+/* This test file is part of GDB, the GNU debugger.
+
+   Copyright 2011 Free Software Foundation, Inc.
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
+
+#include <string>
+
+void
+f (std::string s)
+{
+}
--- src/gdb/testsuite/gdb.cp/no-dmgl-verbose.exp
+++ src/gdb/testsuite/gdb.cp/no-dmgl-verbose.exp	2011-07-01 19:19:27.501841000 +0000
@@ -0,0 +1,38 @@
+# Copyright 2011 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
+
+# Test loading symbols from unrelocated C++ object files.
+
+set testfile no-dmgl-verbose
+set srcfile ${testfile}.cc
+set executable ${testfile}.o
+set binfile ${objdir}/${subdir}/${executable}
+
+if { [skip_cplus_tests] } { continue }
+
+if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" object {c++ debug}] != "" } {
+     untested ${testfile}.exp
+     return -1
+}
+
+clean_restart ${executable}
+
+gdb_test_no_output "set breakpoint pending off"
+
+gdb_breakpoint {'f(std::string)'}
+
+gdb_test {break 'f(std::basic_string<char, std::char_traits<char>, std::allocator<char> >)'} \
+	 {Function ".*" not defined\.} \
+	 "DMGL_VERBOSE-demangled f(std::string) is not defined"


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]