This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA/tracepoint] Make GDB can work with some old GDB server
- From: Hui Zhu <teawater at gmail dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches ml <gdb-patches at sourceware dot org>
- Date: Wed, 6 Jul 2011 10:45:05 +0800
- Subject: Re: [RFA/tracepoint] Make GDB can work with some old GDB server
- References: <BANLkTimuz12OVGoF9tKoV2ikcj9LKFax_g@mail.gmail.com> <m3aacstw4x.fsf@fleche.redhat.com>
Hi Tom,
Thanks for your review.
Fixed and checked in.
Do you think this patch is OK for 7.3 branch?
Best,
Hui
On Wed, Jul 6, 2011 at 02:33, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> ">" == Hui Zhu <teawater@gmail.com> writes:
>
>>> 2011-06-24 ?Hui Zhu ?<teawater@gmail.com>
>>> ? ? ?* remote.c (remote_start_remote): Add TRY_CATCH for
>>> ? ? ?remote_get_trace_status.
>>> ? ? ?* tracepoint.c (disconnect_tracing): Ditto.
>
> It seems reasonable enough to me, but I would prefer that somebody more
> knowledgeable about remote.c review this.
>
>>> + ? ? ?warning(_("%s"), ex.message);
>
> Space before the first open paren.
>
>>> + ? ? ?warning(_("%s"), ex.message);
>
> Likewise.
>
> Tom
>