This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC][patch] Make DCACHE_LINE runtime-settable


> From: Paul Pluzhnikov <ppluzhnikov@google.com>
> Date: Mon, 25 Jul 2011 11:32:51 -0700
> Cc: gdb-patches@sourceware.org
> 
> +* Dcache size (number of lines) and line-size are now runtime-configurable.

Please mention the names of the new commands.

> +@item set dcache size @var{size}
> +@cindex dcache size
> +@kindex dcache size

@kindex should say "set dcache size", because @kindex entries are
commands.  Same in other commands you introduced.

> +@item show dcache size
> +@cindex dcache size
> +@kindex dcache size

It's not useful to have identical index entries pointing to the same
page.  Please remove the second instance.

> +Show maximum number of dcache entries. See also @ref{Caching Remote Data, info dcache}.
                                        ^^
Two spaces.

> +@cindex dcache line-size
> +@kindex dcache line-size
> +Show default size of dcache lines. See also @ref{Caching Remote Data, info dcache}.

Same here (both the second index entry and whitespace between
sentences).

OK with those changes.

Thanks.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]