This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Allow -data-disassemble to run with only -s option
Hi John,
Thanks for your work on this. Some comments below.
John Lindal <support_0384@newplanetsoftware.com> writes:
>> A test case would be nice.
>
> Without the patch, you have to specify both -s and -e. With the
> patch, you can do this:
>
> -data-disassemble -s main
What Tom meant is that you should write a testcase for it. See the
directory gdb/testsuite for examples.
> 2011-08-06 John Lindal <gdb@newplanetsoftware.com>
>
> * mi-cmd-disas.c: Accept only -s option. Automatically set end to end
> of function, or complain that start address is not part of any function.
I think those lines are too long. We try to limit the lines on 80
characteres (some people set a hard limit at 72, IIRC).
> + if (!line_seen && !file_seen && !num_seen && start_seen && !end_seen)
Same issue here.
> + if (find_pc_partial_function (low, &ignore_name, &ignore_low, &high) == 0)
Same issue here.
> *** doc/gdb.texinfo-orig 2011-08-08 17:51:19.000000000 -0700
> --- doc/gdb.texinfo 2011-08-08 17:55:37.000000000 -0700
> ! is the end address. If only @var{start-addr} is specified, then @var{end-addr} is set to the end of the function containing @var{start-addr}.
Same issue here.
Thanks,
Sergio.