This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] [python] Prompt substitution
- From: Phil Muldoon <pmuldoon at redhat dot com>
- To: Pedro Alves <pedro at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org, Tom Tromey <tromey at redhat dot com>
- Date: Tue, 30 Aug 2011 21:22:35 +0100
- Subject: Re: [patch] [python] Prompt substitution
- References: <m3oc0r1tjk.fsf@redhat.com> <m3ipqy2dp6.fsf@fleche.redhat.com> <m362mxxk3f.fsf@redhat.com> <201108302018.03489.pedro@codesourcery.com>
- Reply-to: pmuldoon at redhat dot com
Pedro Alves <pedro@codesourcery.com> writes:
> I believe this to be a bit broken in the annotations (prefix and
> suffix != NULL) case. If the observer changes the prompt, we won't print
> either the prefix or the suffix, but will print directly what the
> observer on the prompt itself only (get_prompt).
Hmm, interesting. It passed the annotations tests :(
> I believe it was not intended for the hook to be able
> to override the prefix and the suffix as well. Right?
> I'm fixing this along with the get-rid-of-prompt-stack
> change.
Nope, not intended to do anything at all with prefix/suffix. AFAIK
prefix/suffix is only used in one particular case of annotations that
matter (basically the control characters that are printed in the
prefix/suffix when annotations > 1).
Anyway, thanks for taking care of this. And thanks for getting rid of
the crufty prompt-stack too!
Cheers
Phil