This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Handle multiple breakpoint hits in Python interface
- From: Tom Tromey <tromey at redhat dot com>
- To: Kevin Pouget <kevin dot pouget at gmail dot com>
- Cc: Eli Zaretskii <eliz at gnu dot org>, gdb-patches at sourceware dot org
- Date: Wed, 31 Aug 2011 11:49:02 -0600
- Subject: Re: [PATCH] Handle multiple breakpoint hits in Python interface
- References: <BANLkTik-ffBpfx4BALF5+Y0xSx_NnaCs7g@mail.gmail.com> <BANLkTinWAR40Fp5TsPubiucTOKygJHHZsw@mail.gmail.com> <m3d3jea6ak.fsf@fleche.redhat.com> <BANLkTik0q4iqSUH9B9ue=0uHzbJqjv32yA@mail.gmail.com> <m3zkm7ucrb.fsf@fleche.redhat.com> <BANLkTi=TJNb57D_UkmPW-ZGfYVaRqGE5=w@mail.gmail.com> <E1QQxDK-0007FP-T4@fencepost.gnu.org> <BANLkTikPMgQ9fwKBcv7zuWHm7mf=hAP86w@mail.gmail.com>
>>>>> "Kevin" == Kevin Pouget <kevin.pouget@gmail.com> writes:
Kevin> 2011-04-30 Kevin Pouget <kevin.pouget@st.com>
Kevin> Handle multiple breakpoint hits in Python interface:
Kevin> * gdb.texinfo (Events In Python): New function documentation:
Kevin> gdb.BreakpointEvent.breakpoints. Indicate that
Kevin> gdb.BreakpointEvent.breakpoint is now deprecated.
[...]
Kevin> + if (PyList_Append (list, (PyObject *) current_bs->breakpoint_at->py_bp_object))
I suggest introducing a PyObject* variable whose value is the second
argument here. Then you don't need to reformat this line or the
subsequent assignment to first_bp:
Kevin> + first_bp = (PyObject *) current_bs->breakpoint_at->py_bp_object;
Kevin> + Py_XDECREF(list);
Missing space before "(".
Otherwise seems reasonable.
Could you please write NEWS patches for your change to the Python API?
Tom