This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] gdbserver: add support for FDPIC loadmaps


On Thursday 29 September 2011 04:58:25, Mike Frysinger wrote:
>         (target_loadmap, !PT_GETDSBT): New definition.

The standard way to write change logs of conditionally compiled
bits is:
          [!PT_GETDSBT] (target_loadmap): New definition.

See <http://www.gnu.org/prep/standards/html_node/Conditional-Changes.html#Conditional-Changes>.

> +#if (defined __bfin__ || defined __frv__ || defined __sh__) && \
> +    !defined PTRACE_GETFDPIC

&& on start of next line.

Otherwise OK.  Thanks.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]