This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Environment variables passed to inferior by MinGW build (PR 10989)


On Sep 26 10:15, Joel Brobecker wrote:
> > >Ping!  Ping!  (2 weeks)
> > 
> > Seems uncontroversial to me (the previous discussion being about
> > entirely different issues).  Let's put it in!
> 
> And I think that 2 weeks without comment from the area maintainer
> is reasonable delay for a Global Maintainer to approve or
> self-approve... If it turns out the area maintainer was away
> during that time, and finds some problems, we can always fix or
> revert.

I was on vacation and I'm also not the area maintainer for windows-nat.c.
I commented to http://sourceware.org/ml/gdb-patches/2011-04/msg00347.html
because what Pierre was doing looked wrong to me.

Eli's patch is ok, IMHO, but it's a pity that Pierre never followed up
to http://sourceware.org/ml/gdb-patches/2011-04/msg00351.html since that
means that now setting environment variables works in Mingw, but not in
Cygwin.  So, as far as I can see, PR #10989 should not have been closed
yet.


Corinna

-- 
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]