This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch 2/2] Fix DW_OP_GNU_implicit_pointer for DWARF32 v3+ on 64-bit arches #2
- From: Tom Tromey <tromey at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 04 Oct 2011 10:00:05 -0600
- Subject: Re: [patch 2/2] Fix DW_OP_GNU_implicit_pointer for DWARF32 v3+ on 64-bit arches #2
- References: <20110926192637.GB32354@host1.jankratochvil.net> <20110926215937.GA4641@host1.jankratochvil.net>
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> Added "quiet" to the testcase, I posted an older variant by mistake.
Jan> On Mon, 26 Sep 2011 21:26:37 +0200, Jan Kratochvil wrote:
Jan> gdb/
Jan> 2011-09-26 Jan Kratochvil <jan.kratochvil@redhat.com>
Jan> Fix DW_OP_GNU_implicit_pointer for DWARF32 v3+ on 64-bit arches.
Jan> * dwarf2-frame.c (execute_stack_op): Initialize ctx->ref_addr_size.
Jan> * dwarf2expr.c (execute_stack_op) <DW_OP_GNU_implicit_pointer>: Use
Jan> ctx-> ref_addr_size. Handle its invalid value.
Jan> * dwarf2expr.h (struct dwarf_expr_context): New field ref_addr_size.
Jan> * dwarf2loc.c (dwarf2_evaluate_loc_desc_full)
Jan> (dwarf2_loc_desc_needs_frame): Initialize ctx->ref_addr_size.
Jan> * dwarf2loc.h (dwarf2_per_cu_ref_addr_size): New declaration.
Jan> * dwarf2read.c (decode_locdesc): Initialize ctx->ref_addr_size.
Jan> (dwarf2_per_cu_ref_addr_size): New function.
Looks good to me. Thanks for doing this.
Tom