This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [python] [patch] PR python/13331
On Oct 24, 2011, at 11:38 AM, Tom Tromey wrote:
>>>>>> "Paul" == Paul Koning <paulkoning@comcast.net> writes:
>
> Paul> In this loop there is an example of what I mentioned: if
> Paul> value_to_value_object returns NULL, exception status has been set, and
> Paul> that should not be overwritten here. On the other hand, there is
> Paul> missing cleanup: any objects added to the tuple before the failing
> Paul> call need to have a DECREF done on them.
>
> Won't decref'ing the tuple do this for us?
> If not then I think there are a lot of similar bugs elsewhere.
> But .. how could it not? That would be weird.
Oops. Yes, you're right. I was worried about the case where you have the tuple half set up. But that case is handled.
Sorry for the confusion.
paul