This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] sim: mn10300: fix typo in if check


> The code looks like it should be doing a bit check, not logical.

> 2011-11-06  Mike Frysinger  <vapier@gentoo.org>
> 
> 	PR sim/9302
> 	* dv-mn103iop.c (write_dedicated_control_reg): Convert && to &.

Indeed. I don't know this processor, and I couldn't easily find
an architecture manual for it.  But the combination of the && being
a nop, and the error message themselves, leads me to agree with you.
I would have asked someone familiar with the architecture, but this
file hasn't been touched since day 1 of the public CVS.

OK.

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]