This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 27/348] Fix -Wsahdow warnings
- From: Tom Tromey <tromey at redhat dot com>
- To: Andrey Smirnov <andrew dot smirnov at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 22 Nov 2011 11:14:44 -0700
- Subject: Re: [PATCH 27/348] Fix -Wsahdow warnings
- References: <871ut08f7j.fsf@gmail.com>
>>>>> "Andrey" == Andrey Smirnov <andrew.smirnov@gmail.com> writes:
Andrey> * bfd-target.c (target_bfd_reopen): Fix -Wshadow
Andrey> warnings.
Andrey> struct target_ops *
Andrey> -target_bfd_reopen (struct bfd *bfd)
Andrey> +target_bfd_reopen (struct bfd *binary_descr)
I think it is more idiomatic to use 'abfd' as the name.
Andrey> + data->bfd = binary_descr;
Andrey> + build_section_table (binary_descr, &data->table.sections, &data->table.sections_end);
This wraps now, so it would need a line break.
Maybe not with "abfd" though.
Tom