This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix build failure due to compiler warning.


> Date: Wed, 16 Nov 2011 01:12:17 -0500 (EST)
> From: David Miller <davem@davemloft.net>
> 
> On Sparc/Linux, __suseconds_t is not a type compatible with 'long' so
> these printf statements trigger a warning and thus a build failure.
> 
> This mirrors the casting already being done for the same exact reason
> in vprintf_unfiltered.
> 
> Ok to commit?

Not sure if you already committed this, but "long int" sounds a bit
pedantic, so I'd prefer to see this with "long".  But either way, this
is ok.

> 2011-11-15  David S. Miller  <davem@davemloft.net>
> 
> 	* utils.c (report_command_stats): Cast delta_wall_time 'tv_sec' and
> 	'tv_usec' to long for printf since these fields have a type which
> 	varies.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]