This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFC: solve Ada-specific problem with linespec patches


> I'm looking for feedback from the Ada-knowledgeable.

You're hired :).

> 2011-11-22  Tom Tromey  <tromey@redhat.com>
> 
> 	* linespec.c (iterate_over_all_matching_symtabs): Call
> 	la_iterate_over_symbols.
> 	(find_function_symbols, decode_variable): Remove Ada special
> 	case.
> 	* language.h (struct language_defn) <la_iterate_over_symbols>: New
> 	field.
> 	* language.c (unknown_language_defn, auto_language_defn)
> 	(local_language_defn): Update.
> 	* c-lang.c (c_language_defn, cplus_language_defn)
> 	(asm_language_defn, minimal_language_defn): Update.
> 	* d-lang.c (d_language_defn): Update.
> 	* f-lang.c (f_language_defn): Update.
> 	* jv-lang.c (java_language_defn): Update.
> 	* m2-lang.c (m2_language_defn): Update.
> 	* objc-lang.c (objc_language_defn): Update.
> 	* opencl-lang.c (opencl_language_defn): Update.
> 	* p-lang.c (pascal_language_defn): Update.
> 	* ada-lang.c (ada_iterate_over_symbols): New function.
> 	(ada_language_defn): Update.
>
> 2011-11-22  Tom Tromey  <tromey@redhat.com>
> 
> 	* gdb.ada/homonym.exp: Add two breakpoint tests.

Thanks Tom, this patch does looks good to me. I especially like how
it allows us to get rid of the if (bla bla & language == ada) blobs.

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]