This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[commit] Further fix the documentation in struct quick_symbol_functions
- From: Joel Brobecker <brobecker at adacore dot com>
- To: gdb-patches at sourceware dot org
- Cc: Joel Brobecker <brobecker at adacore dot com>
- Date: Mon, 28 Nov 2011 17:15:51 -0800
- Subject: [commit] Further fix the documentation in struct quick_symbol_functions
- References: <1322528682-8532-1-git-send-email-brobecker@adacore.com>
This the promised followup on:
http://www.sourceware.org/ml/gdb-patches/2011-11/msg00791.html
gdb/ChangeLog:
* symfile.h (struct quick_symbol_functions): Fix the documentation
of field map_matching_symbols, as symbols are sorted using
strcmp_iw_ordered, not strcmp_iw.
Tested on x86_64-linux by rebuilding GDB. Checked in.
---
gdb/ChangeLog | 6 ++++++
gdb/symfile.h | 14 +++++++-------
2 files changed, 13 insertions(+), 7 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index ce61c09..12dc10a 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,9 @@
+2011-11-28 Joel Brobecker <brobecker@adacore.com>
+
+ * symfile.h (struct quick_symbol_functions): Fix the documentation
+ of field map_matching_symbols, as symbols are sorted using
+ strcmp_iw_ordered, not strcmp_iw.
+
2011-11-28 Paul Hilfinger <hilfinger@adacore.com>
* symfile.h (struct quick_symbol_functions): Update the
diff --git a/gdb/symfile.h b/gdb/symfile.h
index 923bfc9..6b6ffc9 100644
--- a/gdb/symfile.h
+++ b/gdb/symfile.h
@@ -232,14 +232,14 @@ struct quick_symbol_functions
through global symbols if GLOBAL and otherwise static symbols.
Passes NAME, NAMESPACE, and DATA to CALLBACK with each symbol
found. After each block is processed, passes NULL to CALLBACK.
- MATCH must be weaker than strcmp_iw in the sense that
- strcmp_iw(x,y) == 0 --> MATCH(x,y) == 0. ORDERED_COMPARE, if
- non-null, must be an ordering relation compatible with strcmp_iw
- in the sense that
- strcmp_iw(x,y) == 0 --> ORDERED_COMPARE(x,y) == 0
+ MATCH must be weaker than strcmp_iw_ordered in the sense that
+ strcmp_iw_ordered(x,y) == 0 --> MATCH(x,y) == 0. ORDERED_COMPARE,
+ if non-null, must be an ordering relation compatible with
+ strcmp_iw_ordered in the sense that
+ strcmp_iw_ordered(x,y) == 0 --> ORDERED_COMPARE(x,y) == 0
and
- strcmp_iw(x,y) <= 0 --> ORDERED_COMPARE(x,y) <= 0
- (allowing strcmp_iw(x,y) < 0 while ORDERED_COMPARE(x, y) == 0).
+ strcmp_iw_ordered(x,y) <= 0 --> ORDERED_COMPARE(x,y) <= 0
+ (allowing strcmp_iw_ordered(x,y) < 0 while ORDERED_COMPARE(x, y) == 0).
CALLBACK returns 0 to indicate that the scan should continue, or
non-zero to indicate that the scan should be terminated. */
--
1.7.1