This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC/WIP PATCH 08/14] Add support for the '@' core operator


>>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:

Pedro> This adds support for the '@' operator as described in the series
Pedro> description.  I've left this split into a separate patch, as I have
Pedro> tend to think the syntax for filtering per core will end up different.
Pedro> In any case, this adds support for set intersection, so I went ahead
Pedro> with it anyway.

Just some trivia...

Pedro> +/* Implementation of `contains_inferior' method.  */
Pedro> +
Pedro> +static int
Pedro> +core_range_contains_thread (struct itset_elt *base, struct thread_info *thr)

Comment mentions the wrong method.

Pedro> +/* Implementation of `contains_inferior' method.  */
Pedro> +
Pedro> +static int
Pedro> +intersect_contains_thread (struct itset_elt *base, struct thread_info *thr)

Here too.

Pedro>  /* Implementation of `contains_inferior' method.  */
 
Pedro>  static int
Pedro> -state_contains_inferior (struct itset_elt *base, struct inferior *inf)
Pedro> +state_contains_thread (struct itset_elt *base, struct thread_info *thr)

Here too.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]