This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Don't immediately SIGTERM the child of "target remote |".
- From: Doug Evans <dje at google dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: Eli Zaretskii <eliz at gnu dot org>, gdb-patches at sourceware dot org
- Date: Thu, 1 Dec 2011 12:12:57 -0800
- Subject: Re: [RFA] Don't immediately SIGTERM the child of "target remote |".
- References: <20111124000052.14DC12461B1@ruffy.mtv.corp.google.com> <20111127204011.GA4606@host1.jankratochvil.net> <CADPb22QegfZeLPZ9j1RXs4fPbn93Q_onv41OvhsUo9yPeoA6uw@mail.gmail.com> <CADPb22QGxPrrHXDrQHNSev1a4QPTuYwc21B7j=oNoPCaYuB3_g@mail.gmail.com> <20111201194954.GA13230@host2.jankratochvil.net>
On Thu, Dec 1, 2011 at 11:49 AM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> On Thu, 01 Dec 2011 20:46:35 +0100, Doug Evans wrote:
>> +extern int wait_to_die_with_timeout (int pid, int *status, int timeout);
> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?pid_t pid
> just a nitpick
I thought of that but punted on portability grounds.
There are lots of places in gdb that still use int.
It *would* be preferable.
And the code does live inside #ifdef HAVE_WAITPID.