This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix linespec.c vs padding on 32bit targets


>>>>> "Andrew" == Andrew Pinski <andrew.pinski@caviumnetworks.com> writes:

Andrew>   The problem here is there is padding in address_entry so
Andrew> iterative_hash_object on the full object cannot be done as the padding
Andrew> would be some junk.  This causes lots of gdb failures on
Andrew> mips64-linux-gnu.

Thanks Andrew.

Andrew> OK?  Tested on mips64-linux-gnu.

One tiny nit, see below.

Andrew> PS I don't have write access for gdb.

If you have write access to binutils then you do.
If you still don't, let me know and I will commit it.

Andrew> +  hashval_t hash;
Andrew> +  hash = iterative_hash_object (aep->pspace, 0);
Andrew> +  return iterative_hash_object (aep->addr, hash);

The gdb style puts a blank line between declarations and code.
Ok with that change.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]