This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Code formatting [Re: [patch] s390*: watchpoints regression [repost]]
On Sun, 18 Dec 2011 17:52:30 +0100, Eli Zaretskii wrote:
> Any reasons why no one says anything about the alternative I
> suggested? AFAIU, it is free from all the disadvantages mentioned
> here.
You dropped the important part about "still going through the shell", that was
the surprising fact to note there.
If you do not drop that shell part of the text the Pedro's text becomes
shorter, therefore more clear.
Also you just describe
/* This is the main thread still going through the shell, or, no
watchpoint has been set yet. */
->
/* Nothing else to do if this is the main thread, or if no
watchpoints have been set yet. */
additionally the "return" clause there. "return" does not need any comment.
Regards,
Jan