This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [obv] Fix unused-but-set-variable error [Re: [OB] Fix linux-low.c build error]
> This native socket is used for synchronization between gdbserver and
> libinproctrace.so agent. gdbserver puts command into cmd_buf, writes
> one byte in socket to notify gdb_ust_thread (a dedicated thread) and
> wait. gdb_ust_thread picks up command from cmd_buf. When process is
> done, gdb_ust_thread writes one byte again to notify gdbserver and close
> socket. I don't think we have to do something w.r.t write failure. The
> description above is quite user-invisible, so a warning may confuse
> users to some extent, IMO.
Sounds good to me. But wouldn't a comment in the code be useful?
It's probably obvious to you today, but it might not be to someone
else, or even to you in a couple of years from now...
--
Joel