This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC stub-side break conditions 3/5] GDB-side changes
- From: Pedro Alves <palves at redhat dot com>
- To: "Gustavo, Luis" <luis_gustavo at mentor dot com>
- Cc: Eli Zaretskii <eliz at gnu dot org>, gdb-patches at sourceware dot org
- Date: Thu, 12 Jan 2012 19:30:51 +0000
- Subject: Re: [RFC stub-side break conditions 3/5] GDB-side changes
- References: <4F05BA10.3090107@mentor.com> <83y5tlnrsx.fsf@gnu.org> <4F07779A.10808@mentor.com>
On 01/06/2012 10:37 PM, Luis Machado wrote:
> On 01/06/2012 06:44 AM, Eli Zaretskii wrote:
>>> + /* Print whether the remote stub is doing the breakpoint's condition
>>> + evaluation. If GDB is doing the evaluation, don't print anything. */
>>> + if (loc&& is_breakpoint (b)&& loc->cond_bytecode
>>> + && breakpoint_condition_evaluation_mode ()
>>> + != condition_evaluation_gdb)
>>> + {
>>> + ui_out_text (uiout, " (");
>>> + ui_out_field_string (uiout, "condeval",
>>> + breakpoint_condition_evaluation_mode ());
>> I suggest "cond.eval." instead of "condeval". Better yet, how about
>> "evaluated by"?
> Sounds good. I'll make that change.
Isn't that only visible by MI? Are spaces valid in MI field names?