This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFC 1/8] Language independent bits

From: Tom Tromey <tromey at redhat dot com>
To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
Cc: Sergio Durigan Junior <sergiodj at redhat dot com>, gdb-patches at sourceware dot org
Date: Mon, 16 Jan 2012 10:46:05 -0700
Subject: Re: [RFC 1/8] Language independent bits
References: <m3k44s7qej.fsf@gmail.com> <m3aa5o7q3k.fsf@gmail.com> <20120115203420.GA18901@host2.jankratochvil.net>

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

>> +    int expout_size;
Jan> Memory object size does not fit into `int', it should be `size_t'.

I agree, but I think that mixing different kinds of refactorings into
one patch can be unnecessarily complicated and confusing.  The 'int' is
already there today.

Tom

Follow-Ups:
- Re: [RFC 1/8] Language independent bits
  - From: Sergio Durigan Junior

References:
- [RFC 0/8] Beginning to remove globals from parser-defs.h
  - From: Sergio Durigan Junior
- [RFC 1/8] Language independent bits
  - From: Sergio Durigan Junior
- Re: [RFC 1/8] Language independent bits
  - From: Jan Kratochvil

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]