This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PowerPC 32 with Secure PLT


On 01/18/2012 07:33 AM, Michael Eager wrote:
On 01/18/2012 04:08 AM, Joel Brobecker wrote:

+ target = (CORE_ADDR) read_memory_unsigned_integer (target, 4, byte_order);

This is an area where I am not sure, but I think it would be better to use read_memory_typed_address. I think the address type that you want is: builtin_type (gdbarch)->builtin_func_ptr.

I think I'd rather leave the size explicit, rather than making it indirect (and unclear). This routine is only for PowerPC 32 and the size of the value is always four bytes.

--
Michael Eager	 eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306  650-325-8077


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]