This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [2/4] RFC: actually remove the code
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 20 Jan 2012 15:12:41 +0000
- Subject: Re: [2/4] RFC: actually remove the code
- References: <m3lip3xx84.fsf@fleche.redhat.com>
On 01/19/2012 08:18 PM, Tom Tromey wrote:
> Whoops. I meant to say in the previous patch that it lays the
> groundwork for removing some code from infrun.
>
> This patch also comes from:
>
> http://sourceware.org/ml/gdb-patches/2011-09/msg00164.html
>
> This patch actually removes the code. I think this clearly simplifies
> the infrun/catchpoint interface.
>
> This patch differs from Pedro's original patch in one way -- I had to
> add a line to handle_syscall_event. Without this I got test failures.
> I find this addition maybe mildly hacky. We have two target_waitstatus
> objects here: target_last_waitstatus and the one in 'ecs'. The approach
> I took was to update both, but perhaps another valid approach would be
> to only update target_last_waitstatus and pass that down to
> bpstat_stop_status.
It's not clear to me why is handle_syscall_event always ignoring and clobbering
the value.syscall_number the target may have placed there though...
Can't we just get rid of that?
--
Pedro Alves