This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Do not open Python scripts twice #2 [Re: [RFC] Crash sourcing Python script on Windows]
Hello Doug,
On Mon, 23 Jan 2012 22:59:58 +0100, Doug Evans wrote:
> Do you have any data that shows there is a problem with the double opening?
Native GNU/Linux application would never double open files.
It is the similar reason I disable GDB directories relocation in Fedora - as
it is not a normal native application behavior - and in some corner cases it
even breaks execution.
GDB is still a bit exotic codebase nowadays, there is a long way to make it
a normal application with codebase for easy contributions:
http://sourceware.org/gdb/wiki/ProjectIdeas
Here are some specific internal cleanups that are worth doing:
> [I'm kinda uncomfortable with this patch, as is.]
I am uncomfortable with code opening file by filename I have already an opened
FILE * for, that is IMNSHO a clear bug.
But sure if there is consensus it cannot be fixed in FSF GDB I can move the
fix to Fedora GDB, there is now already ~50 to-be-merged patches.
Thanks,
Jan