This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Fix the 2012-01-26 regression by la_get_symbol_name_match_p [Re: Crash regression gdb.cp/no-dmgl-verbose.exp]


> but it should be fixed.  I will check in the patch below, it seems all the
> functions return strcmp-like result.

Duh!

Thanks, Jan. The language hook is very poorly named, I apologize.
Please go ahead and commit this fix immediately as is, and I will
fix the language hook name (and its description!) this weekend.

> gdb/
> 2012-01-27  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	Fix the 2012-01-26 regression by la_get_symbol_name_match_p.
> 	* linespec.c (iterate_name_matcher): Negate the SYMBOL_NAME_MATCH_P
> 	result.
> 
> --- a/gdb/linespec.c
> +++ b/gdb/linespec.c
> @@ -340,7 +340,7 @@ iterate_name_matcher (const char *name, void *d)
>  {
>    const struct symbol_matcher_data *data = d;
>  
> -  if (data->symbol_name_match_p (name, data->lookup_name))
> +  if (data->symbol_name_match_p (name, data->lookup_name) == 0)
>      return 1;
>    return 0;
>  }

Thanks again,
-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]