This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: RFA: fix PR python/13351
- From: Doug Evans <dje at google dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 31 Jan 2012 15:13:50 -0800
- Subject: Re: RFA: fix PR python/13351
- References: <m339avednx.fsf@fleche.redhat.com>
On Tue, Jan 31, 2012 at 1:59 PM, Tom Tromey <tromey@redhat.com> wrote:
> This fixes PR python/13351.
>
> The bug is that gdb.lookup_symbol required a current frame, but this
> restriction doesn't really make sense. ?It is ok to look up global
> symbols without a current frame.
>
> This patch just lifts the restriction.
>
> This requires a doc review.
>
> Built and regtested on x86-64 Fedora 15.
>
> Tom
>
> 2012-01-31 ?Tom Tromey ?<tromey@redhat.com>
>
> ? ? ? ?PR python/13351:
> ? ? ? ?* python/py-symbol.c (gdbpy_lookup_symbol): Work even when there
> ? ? ? ?is no frame.
I think a bit of discussion is needed. [Sorry!]
There is also lookup_global_symbol.
Are we sure we want lookup_symbol to work when there is no frame?
[it doesn't feel very clean to me, but maybe I just need to look at it
differently]