This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Make enable reset disposition
- From: Tom Tromey <tromey at redhat dot com>
- To: Stan Shebs <stanshebs at earthlink dot net>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 06 Feb 2012 12:50:24 -0700
- Subject: Re: [PATCH] Make enable reset disposition
- References: <4F21EE80.104@earthlink.net>
>>>>> "Stan" == Stan Shebs <stanshebs@earthlink.net> writes:
Stan> In the process of developing an additional enablement option (to be
Stan> posted soon), I ran across this little bit of behavior that seems
Stan> wrong; if you do "enable once" and then "enable" on a breakpoint, the
Stan> disposition is unchanged - the breakpoint is still going to get
Stan> disabled after being hit.
Nice find.
Stan> A more complicated solution might be to introduce an additional flavor
Stan> or option of enable command ("enable always"?), but I wouldn't like to
Stan> try to explain the different flavors to users, and chances are that
Stan> nobody would remember it anyway.
If you want to go this way, I think explaining it doesn't have to be too
hard. You could just have the "enable once" docs say, "if you did
`enable once' and then changed your mind, you can `enable always' to
undo it"; and then in the `enable always' paragraph (semi-redundantly)
mention that this command exists just to undo the effect of enable once
and enable delete.
FWIW I didn't even remember the existence of enable once or enable delete.
I think I have never used them.
Stan> I couldn't see anything in the manual that addressed the point either way.
Doug> It feels like adding "always" doesn't muddy the waters any more than
Doug> they already are. :-)
Doug> If one were do do this again, having a new command instead of "enable"
Doug> may be easier for user's to digest and remember.
What Doug said; but with the caveat that I am actually ok with either
approach, as I consider this to be a fairly minor issue; however, if you
choose the simpler route then I think a manual update is in order.
Tom