This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix for Bug 13689: watch (cast) 0xf00bar is not caught as "Cannot watch constant value"

On Sat, Feb 18, 2012 at 9:18 AM, Joel Brobecker <brobecker@adacore.com> wrote:
> The fix looks correct to me. Did you run the testsuite to verify
> your change? It's always a good idea to let us know that you did
> (and on which platform).

Ran full testsuite on x86-64. I observed no new failures.

> Also, would you mind adding a test in gdb.base/watchpoint.exp.
> There are already some tests that verify that you cannot watch
> certain constant expressions, so if you can add one beside it,
> that would be awesome.

Updated patch with test attached. Fixed ChangeLog entry below.

Sterling


2012-02-17  Sterling Augustine  <saugustine@google.com>

	PR 13689:
	* breakpoint.c (watchpoint_exp_is_constant): Add UNOP_CAST to switch.

Attachment: bug_13689.patch
Description: Binary data

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]